Changeset 1248

Timestamp:

08/04/07 16:48:16 (6 years ago)

Author:

ggpolo

Message:

TLGraph stops its drawing timers now, if the widget is destroyed before completing drawings, before, the TLGraph daddy had to do this.

Location:

branch/ggpolo/umitInventory

Files:

• TLChangesTree.py (modified) (1 diff)
• TLGraph.py (modified) (6 diffs)
• Viewer.py (modified) (1 diff)

branch/ggpolo/umitInventory/TLChangesTree.py

@@ -120 +120 @@
         self.datagrabber.use_dict_cursor()
         for key in categories.keys():
+            if not range_start or not range_end:
+                data[key] = { }
+                continue
+
             chgs = self.datagrabber.timerange_changes_data_generic(range_start,
                                                                range_end, key,

branch/ggpolo/umitInventory/TLGraph.py

@@ -148 +148 @@
         
         gtk.Widget.__init__(self)
+
+        self.dontdraw = False
 
         # connector
@@ -493 +495 @@
             self.connector.emit('selection-changed', self.selection)
         
-        
+       
+    def get_cairo_context(self):
+        """
+        Try to return a cairo context.
+        """
+        try:
+            cr = self.window.cairo_create()
+            return cr
+
+        except cairo.Error:
+            # widget is being destroyed (probably)
+            self.dontdraw = True
+
+
     def _calculate_border_reserved(self):
         """
         Calculate space needed to write labels.
         """
-        cr = self.window.cairo_create()
+        #cr = self.window.cairo_create()
+        cr = self.get_cairo_context()
+
+        if not cr:
+            return
+
         if self.graph_label or self.descr_label:
             t = True and self.graph_label or self.descr_label
@@ -915 +935 @@
         This method handles graph animation effect.
         """
+        if self.dontdraw:
+            # entered here but it was configured to not draw anything, 
+            # stop timer then
+            return False
+
         # check if we completed a line segment
         if self.painting_piece == self.divisors:
@@ -930 +955 @@
                 self.cur_point_indx = 0
 
-        cr = self.window.cairo_create()
+        cr = self.get_cairo_context()
+        if not cr:
+            # stop timer, widget is being destroyed (probably)
+            return False
 
         ret = self._draw_by_piece(cr)
@@ -936 +964 @@
         # check if we are done
         if not ret:
-            #print 'Animation completed.'
             self.startup_animation = False
             return False
@@ -1400 +1427 @@
         Draws graph.
         """
-        cr = self.window.cairo_create()
+        if self.dontdraw:
+            return
+
+        cr = self.get_cairo_context()
         cr.rectangle(*event.area)
         cr.clip()

branch/ggpolo/umitInventory/Viewer.py

@@ -740 +740 @@
         Do necessary cleanup before destroying window.
         """
-        if self.timeline.graph.startup_animation: # drawing is going on
-            # stop timer
-            gobject.source_remove(self.timeline.graph.anim_timer)
-
         # remove tip timer if still running
         if self.tip_timer != -1: