Changeset 3576

Timestamp:

08/20/08 06:47:02 (5 years ago)

Author:

nopper

Message:

has_pause/has_stop/has_restart are now used to set the sensitive ofmenu items.
clean action should not raises warnings now.

Updated the TODO accordingly

Location:

branch/PacketManipulator

Files:

• PM/Gui/Tabs/OperationsTab.py (modified) (3 diffs)
• TODO (modified) (2 diffs)

branch/PacketManipulator/PM/Gui/Tabs/OperationsTab.py

@@ -241 +241 @@
         )
 
+        idx = 0
         for lbl, stock, cb in zip(labels, stocks, callbacks):
             action =  gtk.Action(None, lbl, None, stock)
             action.connect('activate', cb, operation)
-
-            menu.append(action.create_menu_item())
+            item = action.create_menu_item()
+            
+            if idx in (1, 2) and not operation.has_pause or \
+               idx == 3 and not operation.has_stop or \
+               idx == 4 and not operation.has_restart:
+                item.set_sensitive(False)
+
+            menu.append(item)
+
+            idx += 1
 
         menu.show_all()
@@ -303 +312 @@
 
     def __on_clear(self, action, operation):
-        # TODO: try a better method
         iter = self.store.get_iter_first()
 
-        while iter:
+        current = len(self.store)
+        
+        while current >= 0:
+            iter = self.store.get_iter_from_string((current, ))
             operation = self.store.get_value(iter, 0)
 
@@ -312 +323 @@
                 self.store.remove(iter)
 
-            iter = self.store.iter_next(iter)
+            current -= 1
 
 class OperationsTab(UmitView):

branch/PacketManipulator/TODO

@@ -9 +9 @@
 - hexview with insert mode
 - plugins system (UmitPlugins) / geoip as example plugin
-- fix the send/receive on windows
 - sending/receiving a list of packets instead of a single
 - switching to pyprocessing?
 - documentation and test cases
-- rewrite the UMPA backend
-- create a method to set docstrings for Scapy (load an xml definitions file)
+- rewrite the UMPA backend (complete/remove)
 - page to show relationships between connections
 - graph page like scapy
@@ -22 +20 @@
 - Implementing a get_icon for operation to use only the object in ListStore
 - same in property grid
-- disable the actions in operation popup menu (has_pause ..)
-- rewrite the clean action
-- implement a popup menu in proto hierarchy to remove layers