Ticket #179 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

nothing happen after loading scan from a file

Reported by: getxsick Owned by: getxsick
Priority: high Milestone: Umit 1.0beta1
Component: RadialNet Version: current svn
Keywords: Cc: luis

Description

just topology is as it was

Attachments

179-casting.patch (1.4 kB) - added by getxsick 4 years ago.

Change History

Changed 4 years ago by getxsick

follow-up: ↓ 3   Changed 4 years ago by getxsick

  • owner changed from luis to getxsick

I think it's not the best patch you can ever seen. I'm not really related with NmapParser? so here is some issues:

  • i think host_tcpsequence is always a dict with predefined keys (index, values, class, difficulty)
    • if so, the first condition if host_tcpsequence: is unnecessary
  • then the better condition would by to check if values of those keys are equivalent None
    • but it's not a fast operation, so rather just ignore it ;)
  • if we don't ignore the point above, then we can skip next condition if host_tcpsequence['index']:

  Changed 4 years ago by getxsick

  • cc luis added
  • status changed from new to assigned

in reply to: ↑ 1 ; follow-up: ↓ 4   Changed 4 years ago by getxsick

Replying to getxsick:

* i think host_tcpsequence is always a dict with predefined keys (index, values, class, difficulty)

I was wrong. It doesn't have to be always available (see NmapParser?.py)

in reply to: ↑ 3   Changed 4 years ago by luis

Replying to getxsick:

Replying to getxsick:

* i think host_tcpsequence is always a dict with predefined keys (index, values, class, difficulty)

I was wrong. It doesn't have to be always available (see NmapParser?.py)

Patch sounds good. I test with several examples and it works. You should commit.

  Changed 4 years ago by getxsick

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.