Ticket #258 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Fisheye bar not being shown

Reported by: lupa Owned by: luis
Priority: medium Milestone: Umit 1.0beta2
Component: RadialNet Version: current svn
Keywords: fisheye radialnet Cc:

Description

When a scan is done, if you go to Topology page on the notebook and click 'Fisheye' button, the application doesn't show the 'Fisheye Bar' that allows the user to adjust fisheye settings.

Attachments

ScanMapperPage.py.diff (392 bytes) - added by lupa 4 years ago.
Add fisheye object to radialnet verticalbox.
ControlWidget.py.diff (3.2 kB) - added by lupa 4 years ago.
Fisheyebar.py.diff (3.6 kB) - added by lupa 4 years ago.
Full patch to fiz the problem
Fisheyebar.py.2.diff (3.6 kB) - added by lupa 4 years ago.
Full patch to fix the problem
Fisheye_bar.diff (3.8 kB) - added by luis 4 years ago.
just ajusting lupa patch

Change History

Changed 4 years ago by lupa

Add fisheye object to radialnet verticalbox.

  Changed 4 years ago by lupa

The attached patch file solves the problem

follow-up: ↓ 3   Changed 4 years ago by gpolo

This makes the default umit window much larger, can that be adjusted in another patch ?

in reply to: ↑ 2   Changed 4 years ago by lupa

Replying to gpolo:

This makes the default umit window much larger, can that be adjusted in another patch ?

That is the bar's minimal size, to solve this problems we have 2 ways: 1- Remove "Fisheye ring selection bar" 2- Edit/remove some text on the Fisheye bar

* Or we can do both of them

  Changed 4 years ago by gpolo

isn't changing its layout an option ?

  Changed 4 years ago by lupa

Fine, i'm working on it

  Changed 4 years ago by lupa

Ok, Fixed

Using the two patchs attached here.

Changed 4 years ago by lupa

  Changed 4 years ago by gpolo

Looking good now, lupa.

Can you align "Fisheye on ring" with "with Interest factor" or does it look too bad ?

Also, if you send another patch, please include all these changes on it and generate it from the trunk root. There is also some problem with your editor which caused João to be written in a different encoding, I can fix this here but just telling you.

Changed 4 years ago by lupa

Full patch to fiz the problem

Changed 4 years ago by lupa

Full patch to fix the problem

follow-up: ↓ 9   Changed 4 years ago by lupa

Well,

I thing that look better like this cause have no "blank spaces". I cut off the "with" on the label to make it cleanner.

Now I believe that this is the Final Version =)

in reply to: ↑ 8   Changed 4 years ago by luis

Replying to lupa:

Well, I thing that look better like this cause have no "blank spaces". I cut off the "with" on the label to make it cleanner. Now I believe that this is the Final Version =)

Well Fisheyebar.py.2.diff is not complete either. No changes on ScanMapperPage?.py.diff

And in copyrights of Fisheyebar.py.2.diff you're with wrong encoding.

Try: Fisheye_bar.diff Someone could test it?

Changed 4 years ago by luis

just ajusting lupa patch

  Changed 4 years ago by gpolo

  • status changed from new to closed
  • resolution set to fixed

I did minor modifications on it and committed on r4441, thanks lupa ;)

Note: See TracTickets for help on using tickets.